Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

prep the release for 2.10 dev sdk #147

Merged
merged 7 commits into from
Jul 22, 2020
Merged

prep the release for 2.10 dev sdk #147

merged 7 commits into from
Jul 22, 2020

Conversation

jakemac53
Copy link
Contributor

Not quite ready to merge (we should publish the version for the 2.9 stable sdk first I think, which is why I let an extra version in there).

@whesse built us a custom sdk with the right version so that travis will be happy. It is a bit of a weird sdk in that still only requires language version 2.9 for our transitive deps, but that makes things a bit easier.

@jakemac53 jakemac53 requested a review from natebosch July 16, 2020 17:03
@jakemac53 jakemac53 marked this pull request as draft July 16, 2020 17:04
@natebosch
Copy link
Contributor

Do we have any doc which lays out the plan for the different SDK and package versions? Are we going to have what that is 2.9-dev only, one 2.9-stable only and one 2.10-dev only?

@jakemac53
Copy link
Contributor Author

The plan is still evolving - I brought it up in an email thread with engprod when the stable branch was cut because there are some obvious issues.

The current plan is to publish a version which allows 2.9 dev and stable (just increase the upper bound) and cherry pick into flutter a commit that pins those versions. Then when they do flip to stable those packages will still work. It should be safe since we have already cut the stable branch so we don't expect any breakage, although breaking cherry picks could happen they would break the flutter bots so we would at least know.

@jakemac53
Copy link
Contributor Author

jakemac53 commented Jul 16, 2020

I am not sure why travis is unhappy here - locally the pub get runs fine :/.

I thought the overrides would allow the sdk constraints to not match up?

Nevermind I needed to pin an extra dep

@natebosch
Copy link
Contributor

SGTM

@jakemac53 jakemac53 marked this pull request as ready for review July 22, 2020 02:20
@jakemac53 jakemac53 merged commit 9a9f7ef into master Jul 22, 2020
@jakemac53 jakemac53 deleted the prep-for-2-10-sdk branch July 22, 2020 02:39
mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 18, 2024
This is in preparation for the actual 2.10 dev sdk release. This package needs to be published and pinned in flutter simultaneously with that release.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants