Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Fix typo in expandIndexed #160

Merged
merged 3 commits into from
Oct 27, 2020
Merged

Fix typo in expandIndexed #160

merged 3 commits into from
Oct 27, 2020

Conversation

natebosch
Copy link
Contributor

No description provided.

@natebosch natebosch requested a review from lrhn October 21, 2020 15:35
@google-cla google-cla bot added the cla: yes label Oct 21, 2020
natebosch referenced this pull request Oct 21, 2020
Add a number of useful extension methods to `List` and `Iterable`, and to a few other types.

A good part of these extensions are backed by the algorithms of `algorithms.dart`, which is expanded to support them:

* Added `quickSort`.
* Add extra optional `Random` argument to `shuffle`.
* Generalize some of the functions in algorithms.dart to work on specific properties of the objects (`binarySearchBy`,
`lowerBoundBy`, `insertionSortBy`, `quickSortBy`, `mergeSortBy`).

The new methods are not exported from the library yet, they are intended to be used through the extension.
@natebosch natebosch requested a review from jakemac53 October 21, 2020 23:58
Copy link
Contributor

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this hasn't yet been released?

@natebosch
Copy link
Contributor Author

It hasn't been, but now it is.

My inclination is to just go with it. The only broken release is a -nullsafety.4 and fixing this now should limit the exposure.

WDYT?

@lrhn
Copy link
Contributor

lrhn commented Oct 27, 2020

LGTM, thanks and sorry.
(And obviously it happened to a method which existed on Iterable with the same behavior, because otherwise it would have been very visible).

@lrhn lrhn merged commit 306e555 into master Oct 27, 2020
@jakemac53
Copy link
Contributor

Yes I am fine with just fixing this since we are still in pre-release

@natebosch natebosch deleted the expand-typo branch October 28, 2020 00:06
mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants