Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Revert "Add count and countWhere extensions." #201

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Conversation

natebosch
Copy link
Contributor

Reverts #196

These cause a conflict internally. Revert for now.

@natebosch natebosch requested a review from lrhn June 24, 2021 21:13
@google-cla google-cla bot added the cla: yes label Jun 24, 2021
@lrhn
Copy link
Contributor

lrhn commented Jun 25, 2021

When would "for now" end?
Do we have a plan to address the conflict?
Should a conflict somewhere be able to block a change that is internally consistent for the package it's added to?

@lrhn lrhn merged commit 75a7a55 into master Jun 25, 2021
@natebosch natebosch deleted the revert-196-count-ext branch June 25, 2021 16:33
@natebosch
Copy link
Contributor Author

When would "for now" end?
Do we have a plan to address the conflict?

When we discussed it last I don't think we had a concrete solution or decision about rolling through the breakages. We had decided that this one could be rolled back since there wasn't a strong need for It. When we come to a decision on dart-lang/core#620 we can either decided to never add these, or decide to add them with some rollout plan.

Should a conflict somewhere be able to block a change that is internally consistent for the package it's added to?

I'm not sure. Maybe? Hopefully not though.

mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants