This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Fix doc comment references among other new lints #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump min SDK to 2.18
kevmoo
commented
Oct 18, 2022
| @@ -231,12 +233,12 @@ void mergeSort<E>(List<E> elements, | |||
| var secondLength = end - middle; | |||
| // secondLength is always the same as firstLength, or one greater. | |||
| var scratchSpace = List<E>.filled(secondLength, elements[start]); | |||
| E Function(E) id = identity; | |||
kevmoo
commented
Oct 18, 2022
| @@ -17,7 +17,7 @@ class CombinedIterableView<T> extends IterableBase<T> { | |||
| /// The iterables that this combines. | |||
| final Iterable<Iterable<T>> _iterables; | |||
|
|
|||
| /// Creates a combined view of [iterables]. | |||
| /// Creates a combined view of [_iterables]. | |||
There was a problem hiding this comment.
type is not public anyway, but the lint flags this reference, for obvious reasons
natebosch
reviewed
Oct 18, 2022
Co-authored-by: Nate Bosch <nbosch@google.com>
Co-authored-by: Nate Bosch <nbosch@google.com>
|
PTAL @natebosch |
natebosch
reviewed
Oct 19, 2022
Co-authored-by: Nate Bosch <nbosch@google.com>
|
@natebosch – PTAL 😄 |
natebosch
approved these changes
Oct 19, 2022
| @@ -169,7 +164,7 @@ bool boolFunc(dynamic x) => true; | |||
| Iterable<dynamic> expandFunc(dynamic x) => [x]; | |||
| dynamic foldFunc(dynamic previous, dynamic next) => previous; | |||
| int compareFunc(dynamic x, dynamic y) => 0; | |||
| var val = 10; | |||
| int val = 10; | |||
There was a problem hiding this comment.
why was this change necessary?
There was a problem hiding this comment.
Type instance variables lint.
There was a problem hiding this comment.
Ah. I don't think we should be turning that one on.
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 18, 2024
…tion#253) Bump min SDK to 2.18
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump min SDK to 2.18