Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Require Dart 3.4, test wasm on 3.4, prepare release #349

Merged
merged 2 commits into from
Jun 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
matrix:
# Add macos-latest and/or windows-latest if relevant for this package.
os: [ubuntu-latest]
sdk: [3.1.0, dev]
sdk: [3.4, dev]
steps:
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29
- uses: dart-lang/setup-dart@f0ead981b4d9a35b37f30d36160575d60931ec30
Expand All @@ -63,4 +63,4 @@ jobs:
if: always() && steps.install.outcome == 'success'
- name: Run Chrome tests - wasm
run: dart test --platform chrome --compiler dart2wasm
if: always() && steps.install.outcome == 'success' && matrix.sdk == 'dev'
if: always() && steps.install.outcome == 'success'
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## 1.19.0-wip
## 1.19.0

- Adds `shuffled` to `IterableExtension`.
- Shuffle `IterableExtension.sample` results.
Expand All @@ -13,7 +13,7 @@
- Deprecate `whereNotNull()` from `IterableNullableExtension`. Use `nonNulls`
instead - this is an equivalent extension available in Dart core since
version 3.0.
- Require Dart `^3.1.0`
- Require Dart `^3.4.0`

## 1.18.0

Expand Down
2 changes: 1 addition & 1 deletion lib/src/canonicalized_map.dart
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ class CanonicalizedMap<C, K, V> implements Map<K, V> {
String toString() => MapBase.mapToString(this);

bool _isValidKey(Object? key) =>
(key is K) && (_isValidKeyFn == null || _isValidKeyFn!(key));
(key is K) && (_isValidKeyFn == null || _isValidKeyFn(key));

/// Creates a `Map<K,V>` (with the original key values).
/// See [toMapOfCanonicalKeys].
Expand Down
4 changes: 2 additions & 2 deletions pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: collection
version: 1.19.0-wip
version: 1.19.0
description: >-
Collections and utilities functions and classes related to collections.
repository: https://github.com/dart-lang/collection
Expand All @@ -9,7 +9,7 @@ topics:
- collections

environment:
sdk: ^3.1.0
sdk: ^3.4.0

dev_dependencies:
dart_flutter_team_lints: ^3.0.0
Expand Down