Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

cleanup #59

Closed
wants to merge 1 commit into from
Closed

cleanup #59

wants to merge 1 commit into from

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented May 17, 2017

Branched from #58

Will cleanup after that merges

@kevmoo kevmoo requested a review from lrhn May 17, 2017 02:56
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@matanlurey
Copy link
Contributor

Rebase?

@googlebot
Copy link

CLAs look good, thanks!

@kevmoo
Copy link
Contributor Author

kevmoo commented May 17, 2017

Done, @matanlurey

matanlurey
matanlurey reviewed May 17, 2017
View reviewed changes
lib/src/unmodifiable_wrappers.dart
import 'empty_unmodifiable_set.dart';
import 'wrappers.dart';

export "dart:collection" show UnmodifiableListView, UnmodifiableMapView;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent " versus ' while you are it.

matanlurey
matanlurey approved these changes May 17, 2017
View reviewed changes
test/algorithms_test.dart
@@ -4,9 +4,10 @@

/// Tests algorithm utilities.

import 'dart:math';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent " versus ' while you are it.

@kevmoo kevmoo closed this Sep 22, 2017
@kevmoo kevmoo deleted the kevmoo_cleanup branch September 22, 2017 16:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matanlurey matanlurey matanlurey approved these changes

@lrhn lrhn Awaiting requested review from lrhn

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevmoo @googlebot @matanlurey