This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Remove usage of Maps.mapToString() #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
DBC: It would be good to document in a comment where this code comes from and why it's duplicated here. |
cbracken
pushed a commit
to google/quiver-dart
that referenced
this pull request
Feb 28, 2018
`Maps.mapToString()` is going to be removed by Dart 2.0. It will be moved to `MapBase.mapToString()`. To avoid bumping the minimum SDK version, we can just copy the implementation (~30 lines) to this package. (This is the same fix that was applied to collection, dart-archive/collection#71.)
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maps.mapToString()is going to be removed by Dart 2.0. It will be moved toMapBase.mapToString(). To avoid bumping the minimum SDK version, we can just copy the implementation (~30 lines) to this package.