Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Deleted typed wrappers, use Dart 2 instead. #86

Merged
merged 2 commits into from
Mar 13, 2018

Conversation

matanlurey
Copy link
Contributor

Copy link
Contributor

@natebosch natebosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much confidence do we have that this isn't breaking, even for users of DDC?

For instance are we sure there aren't any cases where a type failure surfaces at a different point in the execution?

CHANGELOG.md Outdated
## 1.14.8

* Deprecated `Delegating{Name}.typed` static methods in favor of the new Dart 2
`cast` methods. For example, `DelegatingList.typed<String>(list)` can now just
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] remove 'just'

@matanlurey
Copy link
Contributor Author

How much confidence do we have that this isn't breaking, even for users of DDC?

Not 100%, but given the amount of usage, I'd rather wait for bug reports and partially revert if we need to. I'll keep my eye out.

@matanlurey matanlurey merged commit ac08b43 into dart-archive:master Mar 13, 2018
@matanlurey matanlurey deleted the remove-typed-wrappers branch March 13, 2018 04:44
mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 18, 2024
* Deleted typed wrappers, use Dart 2 instead.

* Address feedback.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate TypeSafeWrappers?
3 participants