Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Fix the parameter names in overridden methods to match the source #90

Merged
merged 1 commit into from
Mar 26, 2018

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Mar 26, 2018

Ensures inherited doc comments remain valid

@kevmoo kevmoo requested a review from matanlurey March 26, 2018 17:29
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I think priority wise this is a P10, but ok.

@kevmoo
Copy link
Contributor Author

kevmoo commented Mar 26, 2018

I think priority wise this is a P10, but ok.

I asked for this lint because there were cases in the SDK where doc references were clearly broken.

Just testing it out...

Thanks

@kevmoo kevmoo merged commit eae4081 into master Mar 26, 2018
@kevmoo kevmoo deleted the rename_params branch March 26, 2018 17:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants