This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Fix 2 tests #93
Merged
Fix 2 tests #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up test/wrapper_test.dart signficantly. Add enough type annotations to test/unmodifiable_collection_test.dart to get the necessary inference. Update dependency on SDK to allow using the new `Invocation` constructor.
nex3
approved these changes
May 2, 2018
| void testNoWriteList(List original, List wrapped, String name) { | ||
| List copy = new List.from(original); | ||
| void testNoWriteList(List<int> original, List<int> wrapped, String name) { | ||
| var copy = new List<int>.from(original); |
There was a problem hiding this comment.
Can you use .of() here and below to avoid the explicit annotation?
There was a problem hiding this comment.
Seems so. Good catch. Changed all .from to .of, just for good measure.
test/wrapper_test.dart
Outdated
| List<Type> get typeArguments => const <Type>[]; | ||
|
|
||
| bool get isMethod => _type == METHOD; | ||
| // Parameterization of noSuchMethod. Calles [_action] on every |
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 18, 2024
Fix two tests to be Dart 2 type-safe. Clean up test/wrapper_test.dart signficantly. Add enough type annotations to test/unmodifiable_collection_test.dart to get the necessary inference. Update dependency on SDK to allow using the new `Invocation` constructor.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two tests to be Dart 2 type-safe.
Clean up test/wrapper_test.dart signficantly.
Add enough type annotations to test/unmodifiable_collection_test.dart to get the necessary inference.
Update dependency on SDK to allow using the new
Invocationconstructor.Another partial fix of dart-lang/core#591.