This repository has been archived by the owner on Aug 28, 2024. It is now read-only.
Apply --scope-output
filters after getSourceReport
#498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--scope-output
filters are passed togetSourceReport.libraryFilters
, but there are cases where the report can contain ranges that bypass the filter. This happens when the range has a different library than their enclosing function/class (eg mixins).To fix this we just need to re-apply the filters to the reported ranges. It's still important to pass the filters to
getSourceReport
, because these are pretty rare edge cases and the filtering is still a useful optimisation to reduce the size of the report.Fixes dart-lang/tools#530