-
Notifications
You must be signed in to change notification settings - Fork 197
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
i signed the agreement.
вс, 16 дек. 2018 г. в 22:47, googlebot <notifications@github.com>:
… Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 *Please visit https://cla.developers.google.com/
<https://cla.developers.google.com/> to sign.*
Once you've signed (or fixed any issues), please reply here (e.g. I
signed it!) and we'll verify it.
------------------------------
What to do if you already signed the CLA Individual signers
- It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
Corporate signers
- Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version <https://opensource.google.com/docs/cla/#troubleshoot>).
- The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
- The email used to register you as an authorized contributor must
also be attached to your GitHub account
<https://github.com/settings/emails>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#47 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Afye2d2LutueceJI1nv3pakV-2j_vaO7ks5u5rF9gaJpZM4ZVbfj>
.
|
Thanks very much for the PR, @abicorios. It looks like the code in the related page (https://www.dartlang.org/tutorials/dart-vm/cmdline) has been updated, but not necessarily the text, and not the downloadable code (in this repo). I'm inclined to accept your PR, even though we do say on the page that it hasn't been updated for Dart 2, and we should have a better solution for updating the code in this repo. Unfortunately, our CLA checker doesn't recognize your signature. Did you use the same email account to sign as is associated with your GitHub account? |
@kwalrath, I used the web interface of the Github to do the commit, and I had the private e-mail in settings. Now I change the e-mail status to the public. |
CLAs look good, thanks! |
i tested it for dart2, utf8 must be in lowercase to work