Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

fix utf8 to lowercase #47

Merged
merged 1 commit into from
Dec 18, 2018
Merged

fix utf8 to lowercase #47

merged 1 commit into from
Dec 18, 2018

Conversation

abicorios
Copy link
Contributor

i tested it for dart2, utf8 must be in lowercase to work

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@abicorios
Copy link
Contributor Author

abicorios commented Dec 16, 2018 via email

@kwalrath
Copy link
Contributor

Thanks very much for the PR, @abicorios. It looks like the code in the related page (https://www.dartlang.org/tutorials/dart-vm/cmdline) has been updated, but not necessarily the text, and not the downloadable code (in this repo).

I'm inclined to accept your PR, even though we do say on the page that it hasn't been updated for Dart 2, and we should have a better solution for updating the code in this repo.

Unfortunately, our CLA checker doesn't recognize your signature. Did you use the same email account to sign as is associated with your GitHub account?

@abicorios
Copy link
Contributor Author

@kwalrath, I used the web interface of the Github to do the commit, and I had the private e-mail in settings. Now I change the e-mail status to the public.

@googlebot
Copy link

CLAs look good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants