Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

3 cleanup commits #51

Merged
merged 3 commits into from
Jul 11, 2019
Merged

3 cleanup commits #51

merged 3 commits into from
Jul 11, 2019

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Jul 11, 2019

No description provided.

@kevmoo kevmoo requested a review from kwalrath July 11, 2019 21:14
Copy link
Contributor

@kwalrath kwalrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I believe we’ll need to apply the code changes to site-www (examples), since these are (sadly) duplicated there.

@kwalrath
Copy link
Contributor

/cc @domesticmouse @johnpryan

@kevmoo
Copy link
Contributor Author

kevmoo commented Jul 11, 2019

LGTM. I believe we’ll need to apply the code changes to site-www (examples), since these are (sadly) duplicated there.

Why not just delete them here, then? Duplicate effort seems...less than good.

@kwalrath
Copy link
Contributor

I think we can probably do that, it just hasn’t been a priority. It’ll require a little rewriting in places, and people will no longer be able to easily download the code. But I don’t know if they really download it anyway…

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants