This repository has been archived by the owner on Jan 17, 2024. It is now read-only.
Add Arena Allocator #103
Merged
Add Arena Allocator #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New round of comments on https://dart-review.googlesource.com/c/sdk/+/179180, so this is not yet ready for merging. Thanks for the comments @lrhn ! |
|
I'll first merge https://dart-review.googlesource.com/c/sdk/+/201186 with the addressed comments, and then update this PR. |
|
@mit-mit the Arena has been reviewed by Lasse on https://dart-review.googlesource.com/c/sdk/+/201186. Awaiting your approval to merge this. |
|
RSLGTM |
mit-mit
approved these changes
May 25, 2021
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
May 25, 2021
Addressing follow up comments on https://dart-review.googlesource.com/c/sdk/+/179180 before merging it into `package:ffi` in dart-archive/ffi#103. Also adds the tests from the PR. Change-Id: I9f9e7bdef00c758f0496e73c36e23116c65d95d8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201186 Commit-Queue: Daco Harkes <dacoharkes@google.com> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
dcharkes
added a commit
to dart-lang/native
that referenced
this pull request
Jan 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets merge the Pool from the SDK samples into this package so people can use it.
Technical review by @lrhn earlier: https://dart-review.googlesource.com/c/sdk/+/179180