This repository has been archived by the owner on Jan 17, 2024. It is now read-only.
0.3.0-dev.0 Allocator and Opaque #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mit-mit
suggested changes
Feb 1, 2021
mit-mit
approved these changes
Feb 1, 2021
|
DO NOT DELETE the |
This was referenced Feb 9, 2021
dcharkes
added a commit
to dart-lang/native
that referenced
this pull request
Jan 16, 2024
Changes `Utf8` and `Utf16` to extend `Opaque` instead of `Struct`. This means `.ref` is no longer available and `Pointer<Utf(..)>` should be used. See [breaking change https://github.com/dart-lang/ffi/issues/44622](https://github.com/dart-lang/sdk/issues/44622) for more info. Removes `allocate` and `free`. Instead, introduces `calloc` which implements the new `Allocator` interface. See [breaking change https://github.com/dart-lang/ffi/issues/44621](https://github.com/dart-lang/sdk/issues/44621) for more info. This pre-release requires Dart `2.12.0-265.0.dev` or greater.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a release to address flutter/flutter#75113 and #71.
The CI is failing to run the dev build, because we haven't released this version. "The current Dart SDK version is 2.12.0-259.0.dev." I want to release a version anyway, because we have users on Flutter-master which do have this version.
@mit-mit This is a PR to master, but if we want to keep master only for stable/beta builds we could create a dart-dev branch here instead. (That is what we've done in package:ffigen: https://github.com/dart-lang/ffigen/tree/dart-dev.)
Note that we cannot pin this package release in the Dart SDK yet, because Flutter in g3 does not contain
2.12.0-265.0.devyet.