-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
Fixes #4
Dart SDK master supports nested structs.
69322ce
to
bced324
Compare
We can also target dart-lang/native#540 along with this. And It is better to put these behind a flag in config for users to enable this, since this will only work on dart master branch as of now. I think this should be held off until we merge #122 . |
Super cool stuff! 👍 I second @mannprerak2, we should not merge this into the master branch until nested structs also becomes available in Dart stable. If we merge it into master we can no longer make any changes to @mannprerak2 do you want to do the reviewing for this PR? |
Sure, I was planning to get back to this after #122 has been merged. This can be kept in an experimental branch or made configurable as @mannprerak2 suggested. There's no rush from my side to have this upstream, I got the files already generated. :) |
Sure. |
@jpnurmi I now feel maybe it's better if we do create an experimental branch for this ( Also, we can target dart-lang/native#540 as a separate PR, since it needs to know if a struct had been properly generated to be able to pass it by value correctly. |
Fixes dart-lang/native#541