Skip to content
This repository has been archived by the owner on Nov 1, 2024. It is now read-only.

Commit

Permalink
Migrate to null safety (#139)
Browse files Browse the repository at this point in the history
- Append `-nullsafety.0` to version.
- Set min SDK to `2.12.0-0`.
- Use late field initialization over constructor assignment to clean up
  the handling of backreferences in the different "phases".
- Remove some conditional branches that are impossible to hit.
- Make the non-nullable override of Text nodes explicit with `covariant`.
  • Loading branch information
natebosch authored Jan 25, 2021
2 parents 1eb086f + c1997dc commit 00cd3c2
Show file tree
Hide file tree
Showing 23 changed files with 755 additions and 786 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/test-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: Dart CI

on:
push:
branches: [ master ]
branches: [master]
pull_request:
branches: [ master ]
branches: [master]
schedule:
- cron: "0 0 * * 0"

Expand Down Expand Up @@ -35,7 +35,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
sdk: [2.8.1, dev]
sdk: [dev]
steps:
- uses: actions/checkout@v2
- uses: dart-lang/setup-dart@v0.3
Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## 0.15.0-dev
## 0.15.0-nullsafety.0-dev

- Migrate to null safety.
- Drop `lastPhase`, `beforeRcDataPhase`, and `container` fields from
`HtmlParser` class. These fields never had a value other than `null`.

Expand Down
Loading

0 comments on commit 00cd3c2

Please sign in to comment.