Skip to content
This repository has been archived by the owner on Nov 1, 2024. It is now read-only.

Remove tests expecting >64-bit ints #65

Merged
merged 1 commit into from
Jan 20, 2018
Merged

Remove tests expecting >64-bit ints #65

merged 1 commit into from
Jan 20, 2018

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Jan 20, 2018

@kevmoo kevmoo requested a review from keertip January 20, 2018 01:03
@googlebot googlebot added the cla: yes Google CLA signed label Jan 20, 2018
@kevmoo kevmoo merged commit 50e04c7 into master Jan 20, 2018
@kevmoo kevmoo deleted the fix_for_64_bit branch January 20, 2018 03:24
@@ -152,14 +152,6 @@
"input":"�",
"output":["ParseError", ["Character", "\uFFFD"]]},

{"description":"65-bit hex numeric entity",
Copy link
Contributor

@sigmundch sigmundch Jan 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @jmesserly - possibly Jenny has more insights into this, but I thought these tests were purposely covering >64 bit because it is technically a valid part of the html spec.

My guess is that rather than deleting the tests, we should mark them as failing, or create a new bug entry with the 2 tests so coverage can be added again in the future (likely by changing int.parse with BigInt.parse or something similar.)

@kevmoo
Copy link
Contributor Author

kevmoo commented Jan 26, 2018 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Google CLA signed
Development

Successfully merging this pull request may close these issues.

4 participants