This repository was archived by the owner on Nov 20, 2024. It is now read-only.
camel_case_types support for nonfunction type aliases
#2531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pq
changed the title
camel_case_types support for nonfunction type aliases
bwilkerson
approved these changes
Mar 18, 2021
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| // test w/ `pub run test -N camel_case_types` |
There was a problem hiding this comment.
Consider adding tests for
- generic function type aliases (
typedef f = void Function();) - class type aliases (
class c = Object with M;) - enums (
enum e { a, b }) - mixins (
mixin m {}) - extensions (
extension ext on Object {})
There was a problem hiding this comment.
Ok, wow. enums, mixins and extensions are not supported! 😬 Since that could have some internal impact, I'm going to break that change into a separate issue. Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: dart-lang/sdk#58347.
/cc @bwilkerson