This repository was archived by the owner on Nov 20, 2024. It is now read-only.
avoid_private_typedef_functions support for nonfunction type aliases
#2534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwilkerson
reviewed
Mar 18, 2021
There was a problem hiding this comment.
This rule seems to be very specifically about function types. I can certainly see an argument for generalizing it, but we might want to change the name and we should certainly update the documentation if we decide to go that way. I think it might be worth opening an issue to discuss the question and involve Morgan and Bob, and maybe someone from the Flutter team if it's a lint they use.
|
That sounds reasonable to me. Closing in favor of dart-lang/sdk#58354. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: dart-lang/sdk#58347.
/cc @bwilkerson