This repository was archived by the owner on Nov 20, 2024. It is now read-only.
convert unnecessary .froms to .ofs
#3577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwilkerson
approved these changes
Aug 3, 2022
Contributor
bwilkerson
left a comment
bwilkerson
left a comment
There was a problem hiding this comment.
You just removed some good tests for a possible future lint, but otherwise looks good.
Contributor
Author
I'm hoping the link-backs will help keep that history handy! |
pq
added a commit
that referenced
this pull request
Aug 8, 2022
pq
added a commit
that referenced
this pull request
Aug 8, 2022
* 1.27.0 * Insert reasoning for `avoid_function_literals_in_foreach_calls` lint (#3545) * Update avoid_function_literals_in_foreach_calls.dart * Second attempt * Add a the to make for betterer english * convert unnecessary `.from`s to `.of`s (#3577) * deflake `avoid_redundant_argument_values` * ++ Co-authored-by: Brett Morgan <brett.morgan@gmail.com>
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
* 1.27.0 * Insert reasoning for `avoid_function_literals_in_foreach_calls` lint (dart-archive/linter#3545) * Update avoid_function_literals_in_foreach_calls.dart * Second attempt * Add a the to make for betterer english * convert unnecessary `.from`s to `.of`s (dart-archive/linter#3577) * deflake `avoid_redundant_argument_values` * ++ Co-authored-by: Brett Morgan <brett.morgan@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: dart-lang/sdk#58149 and dart-lang/sdk#58359.
/cc @srawlins @bwilkerson