This repository was archived by the owner on Nov 20, 2024. It is now read-only.
migrate parameter_assignments from traverseNodesInDFS()
#3715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwilkerson
reviewed
Sep 23, 2022
There was a problem hiding this comment.
This is good, but we still visit the function body once for every parameter. Given how expensive visitors are, consider rewriting the logic to something like:
for each parameter,
if the parameter should be checked, add it and information about it to a map
if there are any parameters to check
visit the body looking for assignments to any of those parameters
|
@bwilkerson: comments addressed (thank you!!!) would you mind taking a fresh look? |
bwilkerson
approved these changes
Oct 4, 2022
12 tasks
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
…hive/linter#3715) * migrate from `traverseNodesInDFS()` * imports * fmt * typo * review feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEFORE
AFTER
@bwilkerson: it's still a bit awkward but on the right track I think. Comments welcome!