invariant_boolean: When searching for references reassignment include PostfixExpression and similar, e.g. variable++. #412
Conversation
| .length == | ||
| 0; | ||
| return (AstNode statement) { | ||
| bool isMutation(AstNode n) { |
There was a problem hiding this comment.
This is fairly inefficient because you have to perform multiple is checks for every node, even when you've already determined that it isn't necessary. Perhaps re-structure slightly:
if (n is AssignmentExpression) {
return !identifiers.contains(n.leftHandSide);
} else if (n is PostfixExpression) {
TokenType type = n.operator.type;
return (type == TokenType.PLUS_PLUS || type == TokenType.MINUS_MINUS) && !identifiers.contains(n.operand);
} else ...
}
| return; | ||
| } | ||
|
|
||
| offset++; |
There was a problem hiding this comment.
You might want to introduce other variables so that you can check other operators.
There was a problem hiding this comment.
This is a very good idea, but I am not sure which ones to check, can you please provide a few examples?
There was a problem hiding this comment.
@bwilkerson : thoughts on what @alexeieleusis should check?
There was a problem hiding this comment.
This checks the postfix increment operator, but the rule checks for all four combinations of (prefix | postfix) (increment | decrement) operators. There are three operators that are not being tested, and I think they should be.
There was a problem hiding this comment.
Thanks, I was confused, somehow I thought this was the rule's code. Will add those cases to the test.
|
Fixes dart-lang/sdk#28967 |
| .length == | ||
| 0; | ||
| return (AstNode statement) { | ||
| bool isMutation(AstNode n) { |
| .takeWhile((n) => n != node) | ||
| .where(isMutation) | ||
| .length == | ||
| 0; |
There was a problem hiding this comment.
haha! Irony, I should be using the linter :)
| return; | ||
| } | ||
| } | ||
| } |
… PostfixExpression and similar, e.g. variable++. Fixes https://github.com/dart-lang/linter/issues/337
…ression invariant_boolean: When searching for references reassignment include PostfixExpression and similar, e.g. variable++.
…ression invariant_boolean: When searching for references reassignment include PostfixExpression and similar, e.g. variable++.
…ression invariant_boolean: When searching for references reassignment include PostfixExpression and similar, e.g. variable++.
Fixes dart-lang/sdk#57399