This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Route.dart's support for query parameters, e.g.
?foo=bar&baz=bat
is abysmal.Route.parameters
should parse path and query string #78)onpopstate
events. (No issue opened.)I spent almost 3 full days trying to hack around all of its idiosyncracies and finally gave up in frustration. It turns out to be much easier just to fix route.dart.
Caveats
MockWindow
doesn't have anonPopState
member, and it seems like a lot of work to properly mockonPopState
. There are no existing tests for HTML5 routing that I can mimic — the tests are exclusively for fragment routing.