-
Notifications
You must be signed in to change notification settings - Fork 118
Conversation
PTAL @kevmoo |
What does this get us? |
Impetus for this sweep was dart-archive/dart-tutorials-samples#49 (comment) |
Travis breakage is due to dart-lang/sdk#37324 |
@kevmoo I thought more about your question about what this gets us and I have a different answer now that I'm not knee deep in changes. Modifying the default getting started experience for Stagehand users to include the latest version of the language means that if they are trying out things like UI as Code, they don't get confusing lint warnings and start wondering if everything is broken. I'm curious what you see as the upside to keeping minSDK at a lower bound? This is going to be a very real problem once we want the community to start getting the upside of NNBD. |
Language features is a good reason. Just checking that we have one. 😄 |
@kevmoo can you poke Travis? It should rebuild clean now that |
CHANGELOG.md
Outdated
@@ -1,3 +1,7 @@ | |||
## 3.3.2 | |||
- Updated minimum Dart SDK to 2.3 | |||
- Updated dependency versions across all templates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very Important Comment: We add a period after each list item.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update to 2.4? :/
And updated most of the templates to 2.4. |
PTAL @kwalrath |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks, @domesticmouse!
No description provided.