Skip to content
This repository was archived by the owner on Feb 10, 2025. It is now read-only.

Annotate method error with alwaysThrows annotation. #11

Merged
merged 2 commits into from
Aug 3, 2018
Merged

Conversation

keertip
Copy link
Contributor

@keertip keertip commented Aug 3, 2018

Adding this annotation prevents missing return hints in code where the error method is used.

@keertip keertip requested a review from nex3 August 3, 2018 19:32
CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## 1.0.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be 1.1.0, since telling the compiler that error always throws is kind of a new feature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

pubspec.yaml Outdated
@@ -10,6 +10,7 @@ environment:

dependencies:
charcode: ^1.1.0
meta: ^1.1.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this constraint as wide as possible while still containing @alwaysThrows.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@keertip keertip merged commit 97cdbe2 into master Aug 3, 2018
@keertip keertip deleted the annotate branch August 3, 2018 20:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants