Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Remove use of deprecated FFI features via package:ffi. #29

Merged
merged 2 commits into from
Oct 14, 2019
Merged

Remove use of deprecated FFI features via package:ffi. #29

merged 2 commits into from
Oct 14, 2019

Conversation

sjindel-google
Copy link
Contributor

@mkustermann
Copy link

We're getting close to the D26 release for which this is a prerequisite.

@lambdabaa Would you do us a favor and take a look?

@mkustermann
Copy link

LGTM

@lambdabaa The Utf8 functionality we've added to package:ffi, the Pointer.allocate and Pointer.free are deprecated and will be removed very soon. We're a bit under time pressure for D26 so I hope it's ok with you for us to just merge it. If you have comments we can address them in a follow-up change.

@sjindel-google sjindel-google merged commit 9539cdd into master Oct 14, 2019
@lambdabaa
Copy link
Contributor

@lambdabaa The Utf8 functionality we've added to package:ffi, the Pointer.allocate and Pointer.free are deprecated and will be removed very soon. We're a bit under time pressure for D26 so I hope it's ok with you for us to just merge it. If you have comments we can address them in a follow-up change.

@mkustermann SGTM, though I just merged 439f580 which looks like it also needs to be updated? /cc @sjindel-google @mkustermann

@lambdabaa lambdabaa deleted the sjindel.clean branch October 15, 2019 21:21
@dcharkes
Copy link
Contributor

@lambdabaa I left some comments on the commit. If you build dart locally after https://dart-review.googlesource.com/c/sdk/+/121708 lands, you'll have the latest API (as we will ship with D26). We can also take a look for you tomorrow if you prefer.

truongsinh added a commit to truongsinh/tflite_native that referenced this pull request Nov 13, 2019
@truongsinh
Merge branch 'master' into mobile-flutter
ca67225 
* master:
  Update landed PR with new API (dart-archive#32)
  Resize tensor (dart-archive#24)
  Replace use of asExternalTypedData with asTypedList. (dart-archive#31)
  Remove type argument from structs (dart-archive#30)
  Remove use of deprecated FFI features via package:ffi. (dart-archive#29)
  Enable ci testing on osx (dart-archive#27)
  Whitespace cleanup in .travis.yml and README.md
  Enable and fix a number of lints
  significantly improve performance by `asExternalTypedData` (dart-archive#23)
  v0.3.0
  Issue 18 - Update to latest tflite C API (dart-archive#21)
  Update README.md
  Use Dart 2.5.0 as oldest required pub version (dart-archive#20)

# Conflicts:
#	lib/src/bindings/model.dart
#	lib/src/interpreter.dart
#	lib/src/model.dart
#	lib/src/tensor.dart
#	test/tflite_test.dart
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sjindel-google @mkustermann @lambdabaa @dcharkes