Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

Allow upcoming package:collection version 2.x #81

Closed
wants to merge 1 commit into from
Closed

Conversation

oprypin
Copy link

@oprypin oprypin commented Feb 5, 2024

There will not be a breaking change in package:collection that concerns this package, but currently due to a circular dependency it's not even possible to bump said package's version to 2.0.

$ dart pub get
Resolving dependencies...
Because test >=1.16.0 depends on typed_data ^1.3.0 which depends on collection ^1.15.0, test >=1.16.0 requires collection ^1.15.0.
So, because collection depends on test ^1.16.0 and collection is 2.0.0-wip, version solving failed.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@kevmoo
Copy link
Contributor

kevmoo commented Apr 17, 2024

What's the story here?

@oprypin
Copy link
Author

oprypin commented Apr 17, 2024

There will not be a breaking change in package:collection that concerns this package, but currently due to a circular dependency it's not even possible to bump said package's version to 2.0.

$ dart pub get
Resolving dependencies...
Because test >=1.16.0 depends on typed_data ^1.3.0 which depends on collection ^1.15.0, test >=1.16.0 requires collection ^1.15.0.
So, because collection depends on test ^1.16.0 and collection is 2.0.0-wip, version solving failed.

@devoncarew
Copy link
Contributor

collection only depends on test through a dev_dependency; it would be possible to do dependency_override of typed_data in package collection's pubspec, which would allow its CI to complete. That would mean we wouldn't have to proactively publish a version of typed_data which allows for an unpublished major version of collection.

@oprypin
Copy link
Author

oprypin commented Apr 18, 2024

Thanks @devoncarew. But maybe this is still simpler - why not make a proactive release? A release that increases the version range would have to be done right away anyway.

@kevmoo kevmoo closed this Aug 26, 2024
@kevmoo kevmoo deleted the iterablex2 branch August 26, 2024 21:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants