Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Unused fields and dartdoc references #10

Closed
kevmoo wants to merge 2 commits into from
Closed

Unused fields and dartdoc references #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8acc052
Remove unused fields
kevmoo Oct 20, 2017
a1eacbf
fix dartdoc reference
kevmoo Oct 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/src/channel.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ import 'copy/web_socket_impl.dart';

/// A [StreamChannel] that communicates over a WebSocket.
///
/// This is implemented by classes that use `dart:io` and `dart:html`. The [new
/// WebSocketChannel] constructor can also be used on any platform to connect to
/// use the WebSocket protocol over a pre-existing channel.
/// This is implemented by classes that use `dart:io` and `dart:html`. The
/// [new WebSocketChannel] constructor can also be used on any platform to
/// connect to use the WebSocket protocol over a pre-existing channel.
Copy link
Contributor

@nex3 nex3 Oct 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does dartdoc not work with multi-line references? Is there a bug for that?

Copy link
Contributor

@nex3 nex3 Oct 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked the generated docs, and it looks like this link is working fine, so this change isn't necessary.

///
/// All implementations emit [WebSocketChannelException]s. These exceptions wrap
/// the native exception types where possible.
Expand Down
5 changes: 0 additions & 5 deletions lib/src/copy/web_socket_impl.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ import 'io_sink.dart';
import 'web_socket.dart';

const String webSocketGUID = "258EAFA5-E914-47DA-95CA-C5AB0DC85B11";
const String _webSocketGUID = "258EAFA5-E914-47DA-95CA-C5AB0DC85B11";
const String _clientNoContextTakeover = "client_no_context_takeover";
const String _serverNoContextTakeover = "server_no_context_takeover";
const String _clientMaxWindowBits = "client_max_window_bits";
const String _serverMaxWindowBits = "server_max_window_bits";
Copy link
Contributor

@nex3 nex3 Oct 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copied from the SDK. I don't want to modify it any more than absolutely necessary to get it to work here, because every modification makes merging in new versions harder.


final _random = new Random();

Expand Down