chore: activate some self implemented rules (#553)

* chore: activate prefer-first

* chore: activate prefer-match-file-name

* chore: activate prefer-last

* chore: activate avoid-unnecessary-type-assertions

* chore: update changelog

Author: dkrutskikh

CHANGELOG.md

@@ -33,6 +33,7 @@ dart_code_metrics:
     - test/*
   rules:
     - avoid-unused-parameters
+    - avoid-unnecessary-type-assertions
     - binary-expression-operand-order
     - double-literal-format
     - newline-before-return
@@ -41,6 +42,11 @@ dart_code_metrics:
     - no-equal-then-else
     - no-object-declaration
     - prefer-conditional-expressions
+    - prefer-first
+    - prefer-last
+    - prefer-match-file-name:
+        exclude:
+          - test/**
     - prefer-trailing-comma
 
 linter:

analysis_options.yaml

@@ -24,7 +24,7 @@ import '../config_builder/models/analysis_options.dart';
 import '../utils/yaml_utils.dart';
 import 'analyzer_plugin_utils.dart';
 
-class MetricsAnalyzerPlugin extends ServerPlugin {
+class AnalyzerPlugin extends ServerPlugin {
   static const _analyzer = LintAnalyzer();
 
   final _configs = <AnalysisDriverGeneric, LintAnalysisConfig>{};
@@ -44,7 +44,7 @@ class MetricsAnalyzerPlugin extends ServerPlugin {
   @override
   String get version => '1.0.0-alpha.0';
 
-  MetricsAnalyzerPlugin(ResourceProvider provider) : super(provider);
+  AnalyzerPlugin(ResourceProvider provider) : super(provider);
 
   @override
   void contentChanged(String path) {

lib/src/analyzer_plugin/analyzer_plugin.dart

@@ -6,6 +6,6 @@ import 'package:analyzer_plugin/starter.dart';
 import 'analyzer_plugin.dart';
 
 void start(Iterable<String> _, SendPort sendPort) {
-  ServerPluginStarter(MetricsAnalyzerPlugin(PhysicalResourceProvider.INSTANCE))
+  ServerPluginStarter(AnalyzerPlugin(PhysicalResourceProvider.INSTANCE))
       .start(sendPort);
 }

lib/src/analyzer_plugin/analyzer_plugin_starter.dart

@@ -3,7 +3,6 @@ import 'dart:io';
 
 import 'package:collection/collection.dart';
 import 'package:html/dom.dart';
-import 'package:meta/meta.dart';
 import 'package:path/path.dart' as p;
 
 import '../../../../../reporters/models/html_reporter.dart';
@@ -14,7 +13,7 @@ import '../../../models/summary_lint_report_record.dart';
 import '../../utility_selector.dart';
 import 'components/icon.dart';
 import 'components/issue_details_tooltip.dart';
-import 'models/file_metrics_report.dart';
+import 'models/report_table_record.dart';
 import 'utility_functions.dart';
 
 const _violationLevelFunctionStyle = {
@@ -47,21 +46,6 @@ const _maximumNestingWithViolations = '$_maximumNesting / violations';
 const _codeIssues = 'Issues';
 const _designIssues = 'Design issues';
 
-/// A table record used by [LintHtmlReporter]
-@immutable
-class ReportTableRecord {
-  final String title;
-  final String link;
-
-  final FileMetricsReport report;
-
-  const ReportTableRecord({
-    required this.title,
-    required this.link,
-    required this.report,
-  });
-}
-
 /// Lint HTML reporter.
 ///
 /// Use it to create reports in HTML format.

lib/src/analyzers/lint_analyzer/reporters/reporters_list/html/lint_html_reporter.dart

@@ -0,0 +1,20 @@
+import 'package:meta/meta.dart';
+
+import 'file_metrics_report.dart';
+
+/// A table record
+///
+/// used by html reporter to represent file system entiry with accomulated metrics
+@immutable
+class ReportTableRecord {
+  final String title;
+  final String link;
+
+  final FileMetricsReport report;
+
+  const ReportTableRecord({
+    required this.title,
+    required this.link,
+    required this.report,
+  });
+}

lib/src/analyzers/lint_analyzer/reporters/reporters_list/html/models/report_table_record.dart

@@ -3,7 +3,7 @@ import 'package:html/dom.dart';
 import '../../../models/report.dart';
 import 'components/icon.dart';
 import 'components/report_details_tooltip.dart';
-import 'lint_html_reporter.dart';
+import 'models/report_table_record.dart';
 
 const _violations = 'violations';
 

lib/src/analyzers/lint_analyzer/reporters/reporters_list/html/utility_functions.dart

@@ -1,40 +1,40 @@
 import 'models/rule.dart';
-import 'rules_list/always_remove_listener/always_remove_listener.dart';
-import 'rules_list/avoid_ignoring_return_values/avoid_ignoring_return_values.dart';
-import 'rules_list/avoid_late_keyword/avoid_late_keyword.dart';
-import 'rules_list/avoid_nested_conditional_expressions/avoid_nested_conditional_expressions.dart';
-import 'rules_list/avoid_non_null_assertion/avoid_non_null_assertion.dart';
-import 'rules_list/avoid_preserve_whitespace_false/avoid_preserve_whitespace_false.dart';
-import 'rules_list/avoid_returning_widgets/avoid_returning_widgets.dart';
-import 'rules_list/avoid_unnecessary_setstate/avoid_unnecessary_setstate.dart';
-import 'rules_list/avoid_unnecessary_type_assertions/avoid_unnecessary_type_assertions.dart';
-import 'rules_list/avoid_unused_parameters/avoid_unused_parameters.dart';
-import 'rules_list/avoid_wrapping_in_padding/avoid_wrapping_in_padding.dart';
-import 'rules_list/binary_expression_operand_order/binary_expression_operand_order.dart';
-import 'rules_list/component_annotation_arguments_ordering/component_annotation_arguments_ordering.dart';
-import 'rules_list/double_literal_format/double_literal_format.dart';
-import 'rules_list/member_ordering/member_ordering.dart';
-import 'rules_list/member_ordering_extended/member_ordering_extended.dart';
-import 'rules_list/newline_before_return/newline_before_return.dart';
-import 'rules_list/no_boolean_literal_compare/no_boolean_literal_compare.dart';
-import 'rules_list/no_empty_block/no_empty_block.dart';
-import 'rules_list/no_equal_arguments/no_equal_arguments.dart';
-import 'rules_list/no_equal_then_else/no_equal_then_else.dart';
-import 'rules_list/no_magic_number/no_magic_number.dart';
-import 'rules_list/no_object_declaration/no_object_declaration.dart';
-import 'rules_list/prefer_conditional_expressions/prefer_conditional_expressions.dart';
-import 'rules_list/prefer_const_border_radius/prefer_const_border_radius.dart';
-import 'rules_list/prefer_correct_identifier_length/prefer_correct_identifier_length.dart';
-import 'rules_list/prefer_correct_type_name/prefer_correct_type_name.dart';
-import 'rules_list/prefer_extracting_callbacks/prefer_extracting_callbacks.dart';
-import 'rules_list/prefer_first/prefer_first.dart';
-import 'rules_list/prefer_intl_name/prefer_intl_name.dart';
-import 'rules_list/prefer_last/prefer_last.dart';
-import 'rules_list/prefer_match_file_name/prefer_match_file_name.dart';
-import 'rules_list/prefer_on_push_cd_strategy/prefer_on_push_cd_strategy.dart';
-import 'rules_list/prefer_single_widget_per_file/prefer_single_widget_per_file.dart';
-import 'rules_list/prefer_trailing_comma/prefer_trailing_comma.dart';
-import 'rules_list/provide_correct_intl_args/provide_correct_intl_args.dart';
+import 'rules_list/always_remove_listener/always_remove_listener_rule.dart';
+import 'rules_list/avoid_ignoring_return_values/avoid_ignoring_return_values_rule.dart';
+import 'rules_list/avoid_late_keyword/avoid_late_keyword_rule.dart';
+import 'rules_list/avoid_nested_conditional_expressions/avoid_nested_conditional_expressions_rule.dart';
+import 'rules_list/avoid_non_null_assertion/avoid_non_null_assertion_rule.dart';
+import 'rules_list/avoid_preserve_whitespace_false/avoid_preserve_whitespace_false_rule.dart';
+import 'rules_list/avoid_returning_widgets/avoid_returning_widgets_rule.dart';
+import 'rules_list/avoid_unnecessary_setstate/avoid_unnecessary_setstate_rule.dart';
+import 'rules_list/avoid_unnecessary_type_assertions/avoid_unnecessary_type_assertions_rule.dart';
+import 'rules_list/avoid_unused_parameters/avoid_unused_parameters_rule.dart';
+import 'rules_list/avoid_wrapping_in_padding/avoid_wrapping_in_padding_rule.dart';
+import 'rules_list/binary_expression_operand_order/binary_expression_operand_order_rule.dart';
+import 'rules_list/component_annotation_arguments_ordering/component_annotation_arguments_ordering_rule.dart';
+import 'rules_list/double_literal_format/double_literal_format_rule.dart';
+import 'rules_list/member_ordering/member_ordering_rule.dart';
+import 'rules_list/member_ordering_extended/member_ordering_extended_rule.dart';
+import 'rules_list/newline_before_return/newline_before_return_rule.dart';
+import 'rules_list/no_boolean_literal_compare/no_boolean_literal_compare_rule.dart';
+import 'rules_list/no_empty_block/no_empty_block_rule.dart';
+import 'rules_list/no_equal_arguments/no_equal_arguments_rule.dart';
+import 'rules_list/no_equal_then_else/no_equal_then_else_rule.dart';
+import 'rules_list/no_magic_number/no_magic_number_rule.dart';
+import 'rules_list/no_object_declaration/no_object_declaration_rule.dart';
+import 'rules_list/prefer_conditional_expressions/prefer_conditional_expressions_rule.dart';
+import 'rules_list/prefer_const_border_radius/prefer_const_border_radius_rule.dart';
+import 'rules_list/prefer_correct_identifier_length/prefer_correct_identifier_length_rule.dart';
+import 'rules_list/prefer_correct_type_name/prefer_correct_type_name_rule.dart';
+import 'rules_list/prefer_extracting_callbacks/prefer_extracting_callbacks_rule.dart';
+import 'rules_list/prefer_first/prefer_first_rule.dart';
+import 'rules_list/prefer_intl_name/prefer_intl_name_rule.dart';
+import 'rules_list/prefer_last/prefer_last_rule.dart';
+import 'rules_list/prefer_match_file_name/prefer_match_file_name_rule.dart';
+import 'rules_list/prefer_on_push_cd_strategy/prefer_on_push_cd_strategy_rule.dart';
+import 'rules_list/prefer_single_widget_per_file/prefer_single_widget_per_file_rule.dart';
+import 'rules_list/prefer_trailing_comma/prefer_trailing_comma_rule.dart';
+import 'rules_list/provide_correct_intl_args/provide_correct_intl_args_rule.dart';
 
 final _implementedRules = <String, Rule Function(Map<String, Object>)>{
   AlwaysRemoveListenerRule.ruleId: (config) => AlwaysRemoveListenerRule(config),
@@ -51,8 +51,8 @@ final _implementedRules = <String, Rule Function(Map<String, Object>)>{
       AvoidReturningWidgetsRule(config),
   AvoidUnnecessarySetStateRule.ruleId: (config) =>
       AvoidUnnecessarySetStateRule(config),
-  AvoidUnnecessaryTypeAssertions.ruleId: (config) =>
-      AvoidUnnecessaryTypeAssertions(config),
+  AvoidUnnecessaryTypeAssertionsRule.ruleId: (config) =>
+      AvoidUnnecessaryTypeAssertionsRule(config),
   AvoidUnusedParametersRule.ruleId: (config) =>
       AvoidUnusedParametersRule(config),
   AvoidWrappingInPaddingRule.ruleId: (config) =>
@@ -77,15 +77,16 @@ final _implementedRules = <String, Rule Function(Map<String, Object>)>{
       PreferConditionalExpressionsRule(config),
   PreferConstBorderRadiusRule.ruleId: (config) =>
       PreferConstBorderRadiusRule(config),
-  PreferCorrectIdentifierLength.ruleId: (config) =>
-      PreferCorrectIdentifierLength(config),
-  PreferCorrectTypeName.ruleId: (config) => PreferCorrectTypeName(config),
+  PreferCorrectIdentifierLengthRule.ruleId: (config) =>
+      PreferCorrectIdentifierLengthRule(config),
+  PreferCorrectTypeNameRule.ruleId: (config) =>
+      PreferCorrectTypeNameRule(config),
   PreferExtractingCallbacksRule.ruleId: (config) =>
       PreferExtractingCallbacksRule(config),
   PreferFirstRule.ruleId: (config) => PreferFirstRule(config),
   PreferIntlNameRule.ruleId: (config) => PreferIntlNameRule(config),
   PreferLastRule.ruleId: (config) => PreferLastRule(config),
-  PreferMatchFileName.ruleId: (config) => PreferMatchFileName(config),
+  PreferMatchFileNameRule.ruleId: (config) => PreferMatchFileNameRule(config),
   PreferOnPushCdStrategyRule.ruleId: (config) =>
       PreferOnPushCdStrategyRule(config),
   PreferSingleWidgetPerFileRule.ruleId: (config) =>

lib/src/analyzers/lint_analyzer/rules/rules_factory.dart

@@ -1,4 +1,4 @@
-part of 'always_remove_listener.dart';
+part of 'always_remove_listener_rule.dart';
 
 class _Visitor extends RecursiveAstVisitor<void> {
   final _missingInvocations = <MethodInvocation>[];

lib/src/analyzers/lint_analyzer/rules/rules_list/always_remove_listener/always_remove_listener.dart renamed to lib/src/analyzers/lint_analyzer/rules/rules_list/always_remove_listener/always_remove_listener_rule.dart

@@ -1,4 +1,4 @@
-part of 'avoid_ignoring_return_values.dart';
+part of 'avoid_ignoring_return_values_rule.dart';
 
 class _Visitor extends RecursiveAstVisitor<void> {
   final _statements = <ExpressionStatement>[];

lib/src/analyzers/lint_analyzer/rules/rules_list/always_remove_listener/visitor.dart

@@ -1,4 +1,4 @@
-part of 'avoid_late_keyword.dart';
+part of 'avoid_late_keyword_rule.dart';
 
 class _Visitor extends RecursiveAstVisitor<void> {
   final _declarations = <AstNode>[];

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_ignoring_return_values/avoid_ignoring_return_values.dart renamed to lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_ignoring_return_values/avoid_ignoring_return_values_rule.dart

@@ -1,4 +1,4 @@
-part of 'avoid_nested_conditional_expressions.dart';
+part of 'avoid_nested_conditional_expressions_rule.dart';
 
 class _ConfigParser {
   static const _acceptableLevelConfig = 'acceptable-level';

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_ignoring_return_values/visitor.dart

@@ -1,4 +1,4 @@
-part of 'avoid_nested_conditional_expressions.dart';
+part of 'avoid_nested_conditional_expressions_rule.dart';
 
 class _Visitor extends RecursiveAstVisitor<void> {
   final _nestingLevels = <ConditionalExpression, int>{};

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_late_keyword/avoid_late_keyword.dart renamed to lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_late_keyword/avoid_late_keyword_rule.dart

@@ -1,4 +1,4 @@
-part of 'avoid_non_null_assertion.dart';
+part of 'avoid_non_null_assertion_rule.dart';
 
 class _Visitor extends RecursiveAstVisitor<void> {
   final _expressions = <Expression>[];

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_late_keyword/visitor.dart

@@ -1,4 +1,4 @@
-part of 'avoid_preserve_whitespace_false.dart';
+part of 'avoid_preserve_whitespace_false_rule.dart';
 
 class _Visitor extends RecursiveAstVisitor<void> {
   final _expression = <NamedExpression>[];

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_nested_conditional_expressions/avoid_nested_conditional_expressions.dart renamed to lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_nested_conditional_expressions/avoid_nested_conditional_expressions_rule.dart

@@ -1,4 +1,4 @@
-part of 'avoid_returning_widgets.dart';
+part of 'avoid_returning_widgets_rule.dart';
 
 class _ConfigParser {
   static const _ignoredNamesConfig = 'ignored-names';

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_nested_conditional_expressions/config_parser.dart

@@ -1,4 +1,4 @@
-part of 'avoid_returning_widgets.dart';
+part of 'avoid_returning_widgets_rule.dart';
 
 Declaration? _visitDeclaration(
   Declaration node,

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_nested_conditional_expressions/visitor.dart

@@ -1,4 +1,4 @@
-part of 'avoid_returning_widgets.dart';
+part of 'avoid_returning_widgets_rule.dart';
 
 class _Visitor extends RecursiveAstVisitor<void> {
   final _invocations = <InvocationExpression>[];

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_non_null_assertion/avoid_non_null_assertion.dart renamed to lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_non_null_assertion/avoid_non_null_assertion_rule.dart

@@ -1,4 +1,4 @@
-part of 'avoid_unnecessary_setstate.dart';
+part of 'avoid_unnecessary_setstate_rule.dart';
 
 class _Visitor extends RecursiveAstVisitor<void> {
   static const _checkedMethods = ['initState', 'didUpdateWidget', 'build'];

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_non_null_assertion/visitor.dart

@@ -13,10 +13,10 @@ import '../../rule_utils.dart';
 
 part 'visitor.dart';
 
-class AvoidUnnecessaryTypeAssertions extends CommonRule {
+class AvoidUnnecessaryTypeAssertionsRule extends CommonRule {
   static const String ruleId = 'avoid-unnecessary-type-assertions';
 
-  AvoidUnnecessaryTypeAssertions([Map<String, Object> config = const {}])
+  AvoidUnnecessaryTypeAssertionsRule([Map<String, Object> config = const {}])
       : super(
           id: ruleId,
           severity: readSeverity(config, Severity.style),

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_preserve_whitespace_false/avoid_preserve_whitespace_false.dart renamed to lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_preserve_whitespace_false/avoid_preserve_whitespace_false_rule.dart

@@ -1,4 +1,4 @@
-part of 'avoid_unnecessary_type_assertions.dart';
+part of 'avoid_unnecessary_type_assertions_rule.dart';
 
 class _Visitor extends RecursiveAstVisitor<void> {
   final _expressions = <Expression, String>{};

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_preserve_whitespace_false/visitor.dart

@@ -1,4 +1,4 @@
-part of 'avoid_unused_parameters.dart';
+part of 'avoid_unused_parameters_rule.dart';
 
 class _Visitor extends RecursiveAstVisitor<void> {
   final _unusedParameters = <FormalParameter>[];

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_returning_widgets/avoid_returning_widgets.dart renamed to lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_returning_widgets/avoid_returning_widgets_rule.dart

@@ -1,4 +1,4 @@
-part of 'avoid_wrapping_in_padding.dart';
+part of 'avoid_wrapping_in_padding_rule.dart';
 
 class _Visitor extends RecursiveAstVisitor<void> {
   final _expressions = <Expression>[];

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_returning_widgets/config_parser.dart

@@ -1,4 +1,4 @@
-part of 'binary_expression_operand_order.dart';
+part of 'binary_expression_operand_order_rule.dart';
 
 class _Visitor extends RecursiveAstVisitor<void> {
   final _binaryExpressions = <BinaryExpression>[];

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_returning_widgets/visit_declaration.dart

@@ -1,4 +1,4 @@
-part of 'component_annotation_arguments_ordering.dart';
+part of 'component_annotation_arguments_ordering_rule.dart';
 
 class _ConfigParser {
   static const _orderConfig = 'order';

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_returning_widgets/visitor.dart

@@ -1,4 +1,4 @@
-part of 'component_annotation_arguments_ordering.dart';
+part of 'component_annotation_arguments_ordering_rule.dart';
 
 class _Visitor extends SimpleAstVisitor<List<_ArgumentInfo>> {
   final List<_ArgumentGroup> _groupsOrder;

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unnecessary_setstate/avoid_unnecessary_setstate.dart renamed to lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unnecessary_setstate/avoid_unnecessary_setstate_rule.dart

@@ -1,4 +1,4 @@
-part of 'double_literal_format.dart';
+part of 'double_literal_format_rule.dart';
 
 class _Visitor extends RecursiveAstVisitor<void> {
   final _literals = <DoubleLiteral>[];

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unnecessary_setstate/visitor.dart

@@ -1,4 +1,4 @@
-part of 'member_ordering.dart';
+part of 'member_ordering_rule.dart';
 
 class _ConfigParser {
   static const _orderConfig = 'order';

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unnecessary_type_assertions/avoid_unnecessary_type_assertions.dart renamed to lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unnecessary_type_assertions/avoid_unnecessary_type_assertions_rule.dart

@@ -1,4 +1,4 @@
-part of 'member_ordering.dart';
+part of 'member_ordering_rule.dart';
 
 class _Visitor extends RecursiveAstVisitor<List<_MemberInfo>> {
   final List<_MembersGroup> _groupsOrder;

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unnecessary_type_assertions/visitor.dart

@@ -1,4 +1,4 @@
-part of 'member_ordering_extended.dart';
+part of 'member_ordering_extended_rule.dart';
 
 class _ConfigParser {
   static const _defaultOrderList = [

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unused_parameters/avoid_unused_parameters.dart renamed to lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unused_parameters/avoid_unused_parameters_rule.dart

@@ -1,4 +1,4 @@
-part of '../member_ordering_extended.dart';
+part of '../member_ordering_extended_rule.dart';
 
 @immutable
 class _Annotation {

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unused_parameters/visitor.dart

@@ -1,4 +1,4 @@
-part of '../member_ordering_extended.dart';
+part of '../member_ordering_extended_rule.dart';
 
 @immutable
 class _FieldKeyword {

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_wrapping_in_padding/avoid_wrapping_in_padding.dart renamed to lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_wrapping_in_padding/avoid_wrapping_in_padding_rule.dart

@@ -1,4 +1,4 @@
-part of '../member_ordering_extended.dart';
+part of '../member_ordering_extended_rule.dart';
 
 abstract class _MemberGroup {
   final _Annotation annotation;

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_wrapping_in_padding/visitor.dart

@@ -1,4 +1,4 @@
-part of '../member_ordering_extended.dart';
+part of '../member_ordering_extended_rule.dart';
 
 @immutable
 class _MemberType {