Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

chore: activate some self implemented rules #553

Merged
merged 5 commits into from
Nov 11, 2021
Merged

Conversation

dkrutskikh
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@dkrutskikh dkrutskikh self-assigned this Nov 11, 2021
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #553 (9de8d0b) into master (a9bef96) will increase coverage by 0.02%.
The diff coverage is 63.63%.

❗ Current head 9de8d0b differs from pull request most recent head 8450bcf. Consider uploading reports for the commit 8450bcf to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #553      +/-   ##
==========================================
+ Coverage   85.06%   85.08%   +0.02%     
==========================================
  Files         217      218       +1     
  Lines        4472     4473       +1     
==========================================
+ Hits         3804     3806       +2     
+ Misses        668      667       -1     
Impacted Files Coverage Δ
lib/src/analyzer_plugin/analyzer_plugin.dart 0.00% <0.00%> (ø)
...b/src/analyzer_plugin/analyzer_plugin_starter.dart 0.00% <0.00%> (ø)
...orters/reporters_list/html/lint_html_reporter.dart 0.33% <ø> (-0.34%) ⬇️
...porters/reporters_list/html/utility_functions.dart 87.27% <ø> (ø)
...s_remove_listener/always_remove_listener_rule.dart 100.00% <ø> (ø)
...les/rules_list/always_remove_listener/visitor.dart 100.00% <ø> (ø)
...turn_values/avoid_ignoring_return_values_rule.dart 100.00% <ø> (ø)
...les_list/avoid_ignoring_return_values/visitor.dart 96.96% <ø> (ø)
...st/avoid_late_keyword/avoid_late_keyword_rule.dart 100.00% <ø> (ø)
...r/rules/rules_list/avoid_late_keyword/visitor.dart 100.00% <ø> (ø)
... and 93 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 020abd2...8450bcf. Read the comment docs.

@dkrutskikh dkrutskikh merged commit b5e9f39 into master Nov 11, 2021
@dkrutskikh dkrutskikh deleted the activate-some-rule branch November 11, 2021 18:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants