feat: add 'include-methods' config to 'missing-test-assertion' rule

[orevial]

What is the purpose of this pull request? (put an "X" next to an item)

• Documentation update
• Bug fix
• New rule
• Changes an existing rule
• Add autofixing to a rule
• Add a CLI option
• Add something to the core
• Other, please explain:

Completes issue #1019, PR #1023

What changes did you make? (Give an overview)

This PR aims at completing issue #1019 and PR #1023 about the new missing_test_assertion rule, by adding the possibility to enter additional test methods names to be checked in addition to the default test and testWidgets methods.

This new config might be useful when using dedicated test methods that potentially come from other packages, or just test wrappers written by the developers. E.g. we could create a base companyXTest() method that acts as a wrapper around test/testWidgets and sets some basic configuration for our company tests.

As a side note, I also changed the severity from "style" to "warning" in the doc, seems more appropriate.

Is there anything you'd like reviewers to focus on?

Config name, I can change it if "include-methods" is not clear enough.

[incendial]

@orevial LGTM 🚀 , could you update the changelog?

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[codecov]

Codecov Report

Merging #1026 (307e120) into master (5408c36) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1026      +/-   ##
==========================================
+ Coverage   86.85%   86.86%   +0.01%     
==========================================
  Files         327      327              
  Lines        7014     7021       +7     
==========================================
+ Hits         6092     6099       +7     
  Misses        922      922              

Impacted Files	Coverage Δ
...les_list/missing_test_assertion/config_parser.dart	100.00% <100.00%> (ø)
...ng_test_assertion/missing_test_assertion_rule.dart	100.00% <100.00%> (ø)
...les/rules_list/missing_test_assertion/visitor.dart	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[orevial]

@incendial I'm trying to test the new rule on my project by importing the package from Git but for some reason the rule does not trigger anything, am I missing something ?

dart_code_metrics:
    git:
      url: https://github.com/orevial/dart-code-metrics.git
      ref: feat-missing-test-assertion-rule

My sample unit test :

test('trigger test lint', () {
    // do nothing, should trigger lint
});

[incendial]

@incendial I'm trying to test the new rule on my project by importing the package from Git but for some reason the rule does not trigger anything, am I missing something ?

dart_code_metrics:
    git:
      url: https://github.com/orevial/dart-code-metrics.git
      ref: feat-missing-test-assertion-rule

My sample unit test :

test('trigger test lint', () {
    // do nothing, should trigger lint
});

Hm... have you added the rule to the analysis_options?

[orevial]

Hm... have you added the rule to the analysis_options?

🤦‍♂️

Thank you 😅

[orevial]

@incendial I'm trying to test the new rule on my project by importing the package from Git but for some reason the rule does not trigger anything, am I missing something ?

dart_code_metrics:
    git:
      url: https://github.com/orevial/dart-code-metrics.git
      ref: feat-missing-test-assertion-rule

My sample unit test :

test('trigger test lint', () {
    // do nothing, should trigger lint
});

Hm... have you added the rule to the analysis_options?

Actually even then it's still not using the rule with my incorrect tests...

[incendial]

I'll merge it and take a look a little bit later, right now I don't see anything wrong with the rule

[incendial]

Everything looks fine, just added the rule name to the analysis options and called dart pub run dart_code_metrics:metrics analyze test