Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

fix: ignore override methods for avoid-redundant-async #1060

Merged
merged 1 commit into from
Oct 30, 2022

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

@incendial incendial added type: enhancement New feature or request area-rules labels Oct 30, 2022
@incendial incendial added this to the 5.0.0 milestone Oct 30, 2022
@incendial incendial requested a review from dkrutskikh October 30, 2022 09:19
@incendial incendial self-assigned this Oct 30, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 515

  • Total lines of source code: 9051

  • Total classes: 388

  • Average Cyclomatic Number per line of code: 0.36 / 1

  • Average Source Lines of Code per method: 6

  • Total tech debt: 1880.0 hours

  • Found issues: 5 ⚠

@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Merging #1060 (a84d93d) into master (d8dbead) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1060   +/-   ##
=======================================
  Coverage   84.97%   84.98%           
=======================================
  Files         326      326           
  Lines        7049     7052    +3     
=======================================
+ Hits         5990     5993    +3     
  Misses       1059     1059           
Impacted Files Coverage Δ
...ules/rules_list/avoid_redundant_async/visitor.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@incendial incendial merged commit 9214579 into master Oct 30, 2022
@incendial incendial deleted the improve-avoid-redundant-async-v2 branch October 30, 2022 12:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-rules type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant