Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

refactor: make violations field of summary lint report record as integer #544

Merged
merged 4 commits into from
Nov 5, 2021

Conversation

dkrutskikh
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@dkrutskikh dkrutskikh self-assigned this Nov 5, 2021
@dkrutskikh dkrutskikh changed the title Violations field refactor: make violations field of summary lint report record as integer Nov 5, 2021
@dkrutskikh dkrutskikh requested a review from incendial November 5, 2021 12:21
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #544 (e501e85) into master (6bb140d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head e501e85 differs from pull request most recent head 3ffedea. Consider uploading reports for the commit 3ffedea to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
+ Coverage   84.93%   84.94%   +0.01%     
==========================================
  Files         218      218              
  Lines        4460     4458       -2     
==========================================
- Hits         3788     3787       -1     
+ Misses        672      671       -1     
Impacted Files Coverage Δ
...ics/metrics_list/maintainability_index_metric.dart 100.00% <ø> (ø)
...rics/metrics_list/number_of_parameters_metric.dart 100.00% <ø> (ø)
...r/metrics/metrics_list/weight_of_class_metric.dart 100.00% <ø> (ø)
...analyzers/lint_analyzer/metrics/models/metric.dart 100.00% <ø> (ø)
...nt_analyzer/models/summary_lint_report_record.dart 100.00% <ø> (ø)
...orters/reporters_list/json/lint_json_reporter.dart 100.00% <100.00%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 436140a...3ffedea. Read the comment docs.

@dkrutskikh dkrutskikh merged commit e2919ae into master Nov 5, 2021
@dkrutskikh dkrutskikh deleted the violations-field branch November 5, 2021 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants