Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

feat: add static code diagnostics avoid-unnecessary-type-assertions #549

Conversation

vlkonoshenko
Copy link
Member

@vlkonoshenko vlkonoshenko commented Nov 9, 2021

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix
[X] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #549 (5f997c9) into master (a9bef96) will increase coverage by 0.14%.
The diff coverage is 96.55%.

❗ Current head 5f997c9 differs from pull request most recent head cfb0b5d. Consider uploading reports for the commit cfb0b5d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #549      +/-   ##
==========================================
+ Coverage   85.06%   85.20%   +0.14%     
==========================================
  Files         217      219       +2     
  Lines        4472     4530      +58     
==========================================
+ Hits         3804     3860      +56     
- Misses        668      670       +2     
Impacted Files Coverage Δ
...c/analyzers/lint_analyzer/rules/rules_factory.dart 88.88% <0.00%> (-2.92%) ⬇️
..._assertions/avoid_unnecessary_type_assertions.dart 100.00% <100.00%> (ø)
...ist/avoid_unnecessary_type_assertions/visitor.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9bef96...cfb0b5d. Read the comment docs.

@dkrutskikh dkrutskikh requested a review from incendial November 11, 2021 03:11
@dkrutskikh dkrutskikh merged commit 020abd2 into dart-code-checker:master Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants