Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

fix: fixed issue with type check in avoid-unnecessary-type-assertions #555

Merged
merged 7 commits into from
Nov 16, 2021

Conversation

vlkonoshenko
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fix comparing type in a rule.

@vlkonoshenko vlkonoshenko self-assigned this Nov 11, 2021
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #555 (423aac7) into master (c871a40) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #555      +/-   ##
==========================================
- Coverage   85.29%   85.28%   -0.02%     
==========================================
  Files         220      220              
  Lines        4530     4525       -5     
==========================================
- Hits         3864     3859       -5     
  Misses        666      666              
Impacted Files Coverage Δ
...rtions/avoid_unnecessary_type_assertions_rule.dart 100.00% <ø> (ø)
...ist/avoid_unnecessary_type_assertions/visitor.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c871a40...423aac7. Read the comment docs.

@dkrutskikh dkrutskikh requested a review from incendial November 16, 2021 14:41
@vlkonoshenko vlkonoshenko merged commit 79d8277 into master Nov 16, 2021
@vlkonoshenko vlkonoshenko deleted the fix/avoid_unnecessery_type_assertion branch November 16, 2021 16:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants