Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

feat: improve avoid unnecessary type assertions #560

Merged
merged 4 commits into from
Nov 21, 2021

Conversation

dkrutskikh
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@dkrutskikh dkrutskikh added type: enhancement New feature or request area-rules labels Nov 21, 2021
@dkrutskikh dkrutskikh added this to the 4.7.0 milestone Nov 21, 2021
@dkrutskikh dkrutskikh self-assigned this Nov 21, 2021
@dkrutskikh dkrutskikh changed the title Improve avoid unnecessary type assertions feat: improve avoid unnecessary type assertions Nov 21, 2021
@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #560 (386acc1) into master (bd19b37) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #560      +/-   ##
==========================================
+ Coverage   85.37%   85.42%   +0.05%     
==========================================
  Files         222      222              
  Lines        4566     4570       +4     
==========================================
+ Hits         3898     3904       +6     
+ Misses        668      666       -2     
Impacted Files Coverage Δ
...rtions/avoid_unnecessary_type_assertions_rule.dart 100.00% <100.00%> (ø)
...ist/avoid_unnecessary_type_assertions/visitor.dart 100.00% <100.00%> (ø)
...c/analyzers/lint_analyzer/rules/rules_factory.dart 93.93% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd19b37...386acc1. Read the comment docs.

@dkrutskikh dkrutskikh merged commit 98b79b3 into master Nov 21, 2021
@dkrutskikh dkrutskikh deleted the improve-avoid-unnecessary-type-assertions branch November 21, 2021 10:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-rules type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants