Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

feat: implement avoid-throw-in-catch-block #561

Merged
merged 3 commits into from
Nov 21, 2021

Conversation

dkrutskikh
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@dkrutskikh dkrutskikh added this to the 4.7.0 milestone Nov 21, 2021
@dkrutskikh dkrutskikh self-assigned this Nov 21, 2021
@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #561 (091a88a) into master (98b79b3) will increase coverage by 0.02%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
+ Coverage   85.42%   85.44%   +0.02%     
==========================================
  Files         222      224       +2     
  Lines        4570     4591      +21     
==========================================
+ Hits         3904     3923      +19     
- Misses        666      668       +2     
Impacted Files Coverage Δ
...c/analyzers/lint_analyzer/rules/rules_factory.dart 91.17% <0.00%> (-2.77%) ⬇️
...n_catch_block/avoid_throw_in_catch_block_rule.dart 100.00% <100.00%> (ø)
...rules_list/avoid_throw_in_catch_block/visitor.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98b79b3...091a88a. Read the comment docs.

@dkrutskikh dkrutskikh merged commit e96739f into master Nov 21, 2021
@dkrutskikh dkrutskikh deleted the avoid-throw-in-catch-block branch November 21, 2021 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants