This repository was archived by the owner on Jul 16, 2023. It is now read-only.
feat: add static code diagnostics avoid-global-state.
#624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dart Code Metrics analyze report of dart_code_metrics. ✅Summary
|
Codecov Report
@@ Coverage Diff @@
## master #624 +/- ##
==========================================
+ Coverage 85.92% 85.98% +0.05%
==========================================
Files 230 232 +2
Lines 4917 4936 +19
==========================================
+ Hits 4225 4244 +19
Misses 692 692
Continue to review full report at Codecov.
|
vlkonoshenko
commented
Dec 29, 2021
| class AvoidGlobalStateRule extends CommonRule { | ||
| static const String ruleId = 'avoid-global-state'; | ||
|
|
||
| static const _warning = 'Avoid global state'; |
There was a problem hiding this comment.
Change warning message
dkrutskikh
approved these changes
Dec 29, 2021
incendial
suggested changes
Dec 29, 2021
test/src/analyzers/lint_analyzer/rules/rules_list/avoid_global_state/examples/example.dart
Show resolved
Hide resolved
incendial
approved these changes
Dec 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix
[X] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
#536