Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

fix: avoid-global-state to support static fields #644

Merged
merged 3 commits into from
Jan 13, 2022

Conversation

vlkonoshenko
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

#643

What changes did you make? (Give an overview)

Added support static fields.

@vlkonoshenko vlkonoshenko self-assigned this Jan 13, 2022
@github-actions
Copy link

github-actions bot commented Jan 13, 2022

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

github-actions bot commented Jan 13, 2022

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 357

  • Total lines of source code: 6386

  • Total classes: 240

  • Average Cyclomatic Number per line of code: 0.35 / 1

  • Average Source Lines of Code per method: 6

  • Total tech debt: 1034.0 hours

  • Found issues: 6 ⚠

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #644 (4938c92) into master (62e5602) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #644   +/-   ##
=======================================
  Coverage   86.15%   86.16%           
=======================================
  Files         235      235           
  Lines        5043     5046    +3     
=======================================
+ Hits         4345     4348    +3     
  Misses        698      698           
Impacted Files Coverage Δ
...r/rules/rules_list/avoid_global_state/visitor.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e5602...4938c92. Read the comment docs.

@dkrutskikh dkrutskikh requested a review from incendial January 13, 2022 07:27
@dkrutskikh dkrutskikh merged commit 4a81d13 into master Jan 13, 2022
@dkrutskikh dkrutskikh deleted the 643_support_static_field branch January 13, 2022 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants