-
Notifications
You must be signed in to change notification settings - Fork 272
Conversation
@diegoveloper @lukepighetti hope it's the command you were looking for. Do you want to "beta-test" it? |
Ohh nice!! We'll try the next week |
Dart Code Metrics unused files report of dart_code_metrics. ✅Summary
|
Dart Code Metrics analyze report of dart_code_metrics. ✅Summary
|
Codecov Report
@@ Coverage Diff @@
## master #649 +/- ##
==========================================
- Coverage 86.17% 86.01% -0.17%
==========================================
Files 235 247 +12
Lines 5049 5319 +270
==========================================
+ Hits 4351 4575 +224
- Misses 698 744 +46
Continue to review full report at Codecov.
|
lib/src/analyzers/unused_code_analyzer/models/unused_code_issue.dart
Outdated
Show resolved
Hide resolved
lib/src/analyzers/unused_code_analyzer/public_code_visitor.dart
Outdated
Show resolved
Hide resolved
lib/src/analyzers/unused_code_analyzer/public_code_visitor.dart
Outdated
Show resolved
Hide resolved
.../analyzers/unused_code_analyzer/reporters/reporters_list/json/unused_code_json_reporter.dart
Outdated
Show resolved
Hide resolved
..addFlag( | ||
FlagNames.fatalOnUnused, | ||
help: 'Treat find unused file as fatal.', | ||
// TODO(dkrutrkikh): activate on next major version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@incendial I think for new commands we can activate immediately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep all commands in sync
@incendial please add test like test/src/cli/commands/check_unused_files_command_test.dart and update readme.md at line 123 |
hey @incendial , thanks for this new command, one question, is the I ran the command : And the output contains a lot of It says that the it's excluding those files by default. |
@diegoveloper can we move discussion to the issue #653 ? |
@diegoveloper hi, this should fix the problem #654 |
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain: new command
What changes did you make? (Give an overview)
This implementation is a first iteration of unused code check, it checks for top level declarations usage, such as:
In the next iterations we should add checks for specific class method / properties / getters usage, but this command already brings a lot of value to our users, so let's not block the release on this.