Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

chore: remove @immutable annotation from code. #652

Merged
merged 1 commit into from
Jan 17, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
* feat: support excludes for a separate anti-pattern.
* chore: restrict `analyzer` version to `>=2.4.0 <3.2.0`.
* feat: ignore private members for `check-unused-l10n` command.
* chore: remove `@immutable` annotation from code.

## 4.9.1

Expand Down
2 changes: 0 additions & 2 deletions lib/src/analyzers/lint_analyzer/lint_analysis_config.dart
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
import 'package:glob/glob.dart';
import 'package:meta/meta.dart';

import 'anti_patterns/models/pattern.dart';
import 'metrics/models/metric.dart';
import 'rules/models/rule.dart';

/// Represents converted lint config which contains parsed entities.

@immutable
class LintAnalysisConfig {
final Iterable<Glob> globalExcludes;
final Iterable<Rule> codeRules;
Expand Down
3 changes: 0 additions & 3 deletions lib/src/analyzers/lint_analyzer/lint_config.dart
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
import 'package:meta/meta.dart';

import '../../cli/models/parsed_arguments.dart';
import '../../config_builder/analysis_options_utils.dart';
import '../../config_builder/models/analysis_options.dart';
import 'metrics/metrics_factory.dart';

/// Represents raw lint config which can be merged with other raw configs.
@immutable
class LintConfig {
final Iterable<String> excludePatterns;
final Iterable<String> excludeForMetricsPatterns;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
import 'package:meta/meta.dart';

import '../../models/context_message.dart';

/// An internal model for representing a value computed by a metric.
@immutable
class MetricComputationResult<T> {
/// The actual value computed by the metric.
final T value;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
import 'package:meta/meta.dart';

import '../../models/entity_type.dart';

/// Represents any metric documentation.
@immutable
class MetricDocumentation {
/// The name of the metric.
final String name;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
import 'package:meta/meta.dart';

import '../../models/context_message.dart';
import 'metric_documentation.dart';
import 'metric_value_level.dart';

/// Represents a value computed by the metric.
@immutable
class MetricValue<T> {
/// The id of the computed metric.
final String metricsId;
Expand Down
2 changes: 0 additions & 2 deletions lib/src/analyzers/lint_analyzer/models/context_message.dart
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import 'package:meta/meta.dart';
import 'package:source_span/source_span.dart';

/// Represents a message with a relevant information associated with a diagnostic.
@immutable
class ContextMessage {
/// The message to be displayed to the user.
final String message;
Expand Down
2 changes: 0 additions & 2 deletions lib/src/analyzers/lint_analyzer/models/issue.dart
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
import 'package:meta/meta.dart';
import 'package:source_span/source_span.dart';

import 'replacement.dart';
import 'severity.dart';

/// Represents an issue detected by the analysis rule.
@immutable
class Issue {
/// The id of the rule associated with this issue.
final String ruleId;
Expand Down
3 changes: 0 additions & 3 deletions lib/src/analyzers/lint_analyzer/models/lint_file_report.dart
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
import 'package:meta/meta.dart';

import '../../../reporters/models/file_report.dart';
import 'issue.dart';
import 'report.dart';

/// Represents the metrics report collected for a file.
@immutable
class LintFileReport implements FileReport {
/// The path to the target file.
@override
Expand Down
3 changes: 0 additions & 3 deletions lib/src/analyzers/lint_analyzer/models/replacement.dart
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
import 'package:meta/meta.dart';

/// Represents a single change.
@immutable
class Replacement {
/// The human-readable description of the change to be applied.
final String comment;
Expand Down
2 changes: 0 additions & 2 deletions lib/src/analyzers/lint_analyzer/models/report.dart
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
import 'package:analyzer/dart/ast/ast.dart';
import 'package:collection/collection.dart';
import 'package:meta/meta.dart';
import 'package:source_span/source_span.dart';

import '../metrics/models/metric_value.dart';
import '../metrics/models/metric_value_level.dart';

/// Represents a metrics report collected for an entity.
@immutable
class Report {
/// The source code location of the target entity.
final SourceSpan location;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import 'package:analyzer/dart/ast/ast.dart';
import 'package:meta/meta.dart';

import 'class_type.dart';

/// Represents a declaration of a class / mixin / extension.
@immutable
class ScopedClassDeclaration {
/// The type of the declared class entity.
final ClassType type;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
import 'package:analyzer/dart/ast/ast.dart';
import 'package:meta/meta.dart';

import 'function_type.dart';
import 'scoped_class_declaration.dart';

/// Represents a declaration of function / method.
@immutable
class ScopedFunctionDeclaration {
/// The type of the declared function entity.
final FunctionType type;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
import 'package:meta/meta.dart';

import 'summary_lint_report_record_status.dart';

/// Represents a summary for a lint report.
@immutable
class SummaryLintReportRecord<T> {
final SummaryLintReportRecordStatus status;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
import 'package:meta/meta.dart';

import 'code_climate_issue_category.dart';
import 'code_climate_issue_location.dart';
import 'code_climate_issue_severity.dart';

/// Represents a Code Climate issue.
@immutable
class CodeClimateIssue {
static const String type = 'issue';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import 'package:meta/meta.dart';
import 'package:source_span/source_span.dart';

/// Represents a Code Climate issue location.
@immutable
class CodeClimateIssueLocation {
final String path;
final SourceSpan location;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
// ignore_for_file: public_member_api_docs

import 'package:meta/meta.dart';

@immutable
class FileMetricsReport {
final int averageArgumentsCount;
final int argumentsCountViolations;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
// ignore_for_file: public_member_api_docs

import 'package:meta/meta.dart';

import '../../../../metrics/models/metric_value.dart';

@immutable
class FunctionMetricsReport {
final MetricValue<int> cyclomaticComplexity;
final MetricValue<int> sourceLinesOfCode;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
import 'package:meta/meta.dart';

import 'file_metrics_report.dart';

/// A table record
///
/// used by html reporter to represent file system entiry with accomulated metrics
@immutable
class ReportTableRecord {
final String title;
final String link;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import 'dart:convert';
import 'dart:io';

import 'package:meta/meta.dart';
import 'package:source_span/source_span.dart';

import '../../../../../reporters/models/json_reporter.dart';
Expand All @@ -16,7 +15,6 @@ import '../../../models/summary_lint_report_record.dart';
/// Lint JSON reporter.
///
/// Use it to create reports in JSON format.
@immutable
class LintJsonReporter extends JsonReporter<LintFileReport,
SummaryLintReportRecord<Object>, void> {
const LintJsonReporter(IOSink output) : super(output, 2);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,6 @@ abstract class IntlBaseVisitor extends GeneralizingAstVisitor<void> {
}
}

@immutable
abstract class IntlBaseIssue {
final AstNode node;
final String? nameFailure;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/ast/token.dart';
import 'package:analyzer/dart/ast/visitor.dart';
import 'package:collection/collection.dart';
import 'package:meta/meta.dart';

import '../../../../../utils/node_utils.dart';
import '../../../../../utils/string_extensions.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ class _Visitor extends SimpleAstVisitor<List<_ArgumentInfo>> {
node.name.name == 'Component' && node.atSign.type == TokenType.AT;
}

@immutable
class _ArgumentGroup {
final String name;
final Iterable<String> arguments;
Expand Down Expand Up @@ -139,7 +138,6 @@ class _ArgumentGroup {
_groupsOrder.firstWhereOrNull((group) => group.arguments.contains(name));
}

@immutable
class _ArgumentInfo {
final NamedExpression argument;
final _ArgumentOrder argumentOrder;
Expand All @@ -150,7 +148,6 @@ class _ArgumentInfo {
});
}

@immutable
class _ArgumentOrder {
final bool isWrong;
final _ArgumentGroup argumentGroup;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/ast/visitor.dart';
import 'package:collection/collection.dart';
import 'package:meta/meta.dart';

import '../../../../../utils/node_utils.dart';
import '../../../../../utils/string_extensions.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ class _Visitor extends RecursiveAstVisitor<List<_MemberInfo>> {
_groupsOrder.indexOf(lastMemberGroup) > _groupsOrder.indexOf(memberGroup);
}

@immutable
class _MembersGroup {
final String name;

Expand Down Expand Up @@ -197,7 +196,6 @@ class _MembersGroup {
_groupsOrder.firstWhereOrNull((group) => group.name == name);
}

@immutable
class _Annotation {
final String name;
final _MembersGroup group;
Expand Down Expand Up @@ -234,7 +232,6 @@ class _Annotation {
_annotations.firstWhereOrNull((annotation) => annotation.name == name);
}

@immutable
class _MemberInfo {
final ClassMember classMember;
final _MemberOrder memberOrder;
Expand All @@ -245,7 +242,6 @@ class _MemberInfo {
});
}

@immutable
class _MemberOrder {
final bool isWrong;
final bool isAlphabeticallyWrong;
Expand All @@ -262,7 +258,6 @@ class _MemberOrder {
});
}

@immutable
class _MemberNames {
final String currentName;
final String? previousName;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/ast/visitor.dart';
import 'package:analyzer/dart/element/nullability_suffix.dart';
import 'package:collection/collection.dart';
import 'package:meta/meta.dart';

import '../../../../../utils/node_utils.dart';
import '../../../lint_utils.dart';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
part of '../member_ordering_extended_rule.dart';

@immutable
class _Annotation {
final String name;
final String? publicName;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
part of '../member_ordering_extended_rule.dart';

@immutable
class _FieldKeyword {
final String type;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
part of '../member_ordering_extended_rule.dart';

@immutable
class _MemberType {
final String type;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
part of '../member_ordering_extended_rule.dart';

@immutable
class _Modifier {
final String type;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,6 @@ class _Visitor extends RecursiveAstVisitor<List<_MemberInfo>> {
group.annotation == parsedGroup.annotation);
}

@immutable
class _MemberInfo {
final ClassMember classMember;
final _MemberOrder memberOrder;
Expand All @@ -224,7 +223,6 @@ class _MemberInfo {
});
}

@immutable
class _MemberOrder {
final bool isWrong;
final bool isAlphabeticallyWrong;
Expand All @@ -243,7 +241,6 @@ class _MemberOrder {
});
}

@immutable
class _MemberNames {
final String currentName;
final String? previousName;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/ast/token.dart';
import 'package:analyzer/dart/ast/visitor.dart';
import 'package:meta/meta.dart';

import '../../../../../utils/node_utils.dart';
import '../../../lint_utils.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ class _Visitor extends RecursiveAstVisitor<void> {
}
}

@immutable
class _StatementInfo {
final IfStatement statement;
final AstNode unwrappedThenStatement;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import 'package:analyzer/dart/ast/ast.dart';
import 'package:collection/collection.dart';
import 'package:meta/meta.dart';

import '../../../../../utils/node_utils.dart';
import '../../../../../utils/object_extensions.dart';
Expand Down
Loading