Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

feat: add prefer-async-await rule #686

Merged
merged 3 commits into from
Feb 7, 2022
Merged

feat: add prefer-async-await rule #686

merged 3 commits into from
Feb 7, 2022

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix
[X] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

@incendial incendial added type: enhancement New feature or request area-rules labels Feb 6, 2022
@incendial incendial added this to the 4.11.0 milestone Feb 6, 2022
@incendial incendial requested a review from dkrutskikh February 6, 2022 12:42
@incendial incendial self-assigned this Feb 6, 2022
@incendial
Copy link
Member Author

@roman-petrov could you please take a look too? Maybe I missed some cases.

@github-actions
Copy link

github-actions bot commented Feb 6, 2022

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

github-actions bot commented Feb 6, 2022

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 387

  • Total lines of source code: 6896

  • Total classes: 259

  • Average Cyclomatic Number per line of code: 0.35 / 1

  • Average Source Lines of Code per method: 6

  • Total tech debt: 1126.0 hours

  • Found issues: 6 ⚠

@codecov
Copy link

codecov bot commented Feb 6, 2022

Codecov Report

Merging #686 (35d5b7b) into master (6ea082e) will increase coverage by 0.02%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #686      +/-   ##
==========================================
+ Coverage   86.30%   86.33%   +0.02%     
==========================================
  Files         253      255       +2     
  Lines        5412     5431      +19     
==========================================
+ Hits         4671     4689      +18     
- Misses        741      742       +1     
Impacted Files Coverage Δ
...c/analyzers/lint_analyzer/rules/rules_factory.dart 94.66% <0.00%> (-1.28%) ⬇️
...st/prefer_async_await/prefer_async_await_rule.dart 100.00% <100.00%> (ø)
...r/rules/rules_list/prefer_async_await/visitor.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ea082e...35d5b7b. Read the comment docs.

@roman-petrov
Copy link
Contributor

@incendial this looks promising! I am a bit ill and surely will take closer look in a couple of days.

@incendial
Copy link
Member Author

@incendial this looks promising! I am a bit ill and surely will take closer look in a couple of days.

Sure, get well soon!

location: nodeLocation(
node: invocation,
source: source,
withCommentOrMetadata: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@incendial please set as false

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@incendial incendial requested a review from dkrutskikh February 7, 2022 16:27
@dkrutskikh dkrutskikh merged commit 7a05c6e into master Feb 7, 2022
@dkrutskikh dkrutskikh deleted the prefer-async-await branch February 7, 2022 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-rules type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants