Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

feat: add static code diagnostics avoid-border-all. #691

Merged
merged 10 commits into from
Feb 15, 2022

Conversation

vlkonoshenko
Copy link
Member

@vlkonoshenko vlkonoshenko commented Feb 12, 2022

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix
[X] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Border.all({
Color color = const Color(0xFF000000),
double width = 1.0,
BorderStyle style = BorderStyle.solid,
}) // LINT

Is there anything you'd like reviewers to focus on?

@github-actions
Copy link

github-actions bot commented Feb 12, 2022

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

github-actions bot commented Feb 12, 2022

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 393

  • Total lines of source code: 6967

  • Total classes: 261

  • Average Cyclomatic Number per line of code: 0.35 / 1

  • Average Source Lines of Code per method: 6

  • Total tech debt: 1142.0 hours

  • Found issues: 6 ⚠

@codecov
Copy link

codecov bot commented Feb 12, 2022

Codecov Report

Merging #691 (8d49849) into master (3d92124) will increase coverage by 0.07%.
The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #691      +/-   ##
==========================================
+ Coverage   86.42%   86.50%   +0.07%     
==========================================
  Files         255      257       +2     
  Lines        5452     5490      +38     
==========================================
+ Hits         4712     4749      +37     
- Misses        740      741       +1     
Impacted Files Coverage Δ
...c/analyzers/lint_analyzer/rules/rules_factory.dart 96.05% <0.00%> (-1.29%) ⬇️
...s_list/avoid_border_all/avoid_border_all_rule.dart 100.00% <100.00%> (ø)
...zer/rules/rules_list/avoid_border_all/visitor.dart 100.00% <100.00%> (ø)
...border_radius/prefer_const_border_radius_rule.dart 100.00% <100.00%> (ø)
...es/rules_list/avoid_returning_widgets/visitor.dart 100.00% <0.00%> (ø)
...les_list/no_magic_number/no_magic_number_rule.dart 100.00% <0.00%> (ø)
...eturning_widgets/avoid_returning_widgets_rule.dart 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d92124...8d49849. Read the comment docs.

@dkrutskikh dkrutskikh merged commit ced086d into master Feb 15, 2022
@dkrutskikh dkrutskikh deleted the rule/avoid_border_all branch February 15, 2022 09:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants