Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

fix: support index expressions for no-magic-number rule #755

Merged
merged 1 commit into from
Mar 26, 2022

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

@incendial incendial added this to the 5.0.0 milestone Mar 22, 2022
@incendial incendial requested a review from dkrutskikh March 22, 2022 18:15
@incendial incendial self-assigned this Mar 22, 2022
@github-actions
Copy link

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 415

  • Total lines of source code: 7342

  • Total classes: 283

  • Average Cyclomatic Number per line of code: 0.34

  • Average Source Lines of Code per method: 6

  • Total tech debt: 1230.0 hours

  • Found issues: 6 ⚠

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #755 (bbab151) into master (6ae2211) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head bbab151 differs from pull request most recent head 11e2254. Consider uploading reports for the commit 11e2254 to get more accurate results

@@           Coverage Diff           @@
##           master     #755   +/-   ##
=======================================
  Coverage   86.90%   86.90%           
=======================================
  Files         273      273           
  Lines        5788     5790    +2     
=======================================
+ Hits         5030     5032    +2     
  Misses        758      758           
Impacted Files Coverage Δ
...les_list/no_magic_number/no_magic_number_rule.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ae2211...11e2254. Read the comment docs.

@dkrutskikh dkrutskikh merged commit c0613e5 into master Mar 26, 2022
@dkrutskikh dkrutskikh deleted the no-magic-number-index-expression branch March 26, 2022 12:32
@incendial incendial modified the milestones: 5.0.0, 4.14.0 Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants