Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

fix: cover more cases in "prefer-immediate-return" rule #760

Merged
merged 2 commits into from
Mar 27, 2022
Merged

fix: cover more cases in "prefer-immediate-return" rule #760

merged 2 commits into from
Mar 27, 2022

Conversation

roman-petrov
Copy link
Contributor

Fixes #754

I just added more test cases and visitor now overrides visitBlock instead of overriding visitBlockFunctionBody to cover these cases in prefer-immediate-return rule.

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #760 (a9d02dc) into master (76705e5) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #760   +/-   ##
=======================================
  Coverage   86.99%   86.99%           
=======================================
  Files         273      273           
  Lines        5784     5784           
=======================================
  Hits         5032     5032           
  Misses        752      752           
Impacted Files Coverage Δ
...es/rules_list/prefer_immediate_return/visitor.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76705e5...a9d02dc. Read the comment docs.

@roman-petrov
Copy link
Contributor Author

"Auto Author Assign" check failed - seems this is not related to my PR so it should be ready for review.

@dkrutskikh dkrutskikh added area-rules type: enhancement New feature or request labels Mar 27, 2022
@dkrutskikh dkrutskikh merged commit 8b16cbb into dart-code-checker:master Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-rules type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] prefer-immediate-return does not work inside nested blocks
3 participants