-
Notifications
You must be signed in to change notification settings - Fork 20
add a CI check that the readme file is up-to-date #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
Hmm, it looks like |
@@ -179,6 +179,13 @@ base mixin DashCliSupport on ToolsSupport, LoggingSupport, RootsTrackingSupport | |||
); | |||
} | |||
|
|||
static final List<Tool> allTools = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: consider looping through this list in the initialize method so that it is less likely a new tool is added to initialize and not added here. You'd have to store that tools with their associated callback here.
buf.writeln('### $category'); | ||
buf.writeln(''); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: use cascades
Yeah it is, no good way to avoid it that I am aware of. We could depend on a specific hash and that might get us a cache hit (if we also cache the pub cache on GitHub actions), so it would speed up CI a fair bit. |
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 | ||
- uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c | ||
|
||
- run: dart pub get |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could just merge this into the job above to avoid the extra setup work 🤷♂️ . This repo isn't large enough to really need multiple jobs.
Note that this PR also changes the format of the list of tools; it adds some categorization (we have a bunch of tools now); https://github.com/dart-lang/ai/blob/f8fb7408f39ac9dfa1d83ad0ebb4b0934e2cd8a9/pkgs/dart_mcp_server/README.md .
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.