Skip to content

Update spec to 2025-03-26 #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 17, 2025
Merged

Update spec to 2025-03-26 #70

merged 13 commits into from
Apr 17, 2025

Conversation

jakemac53
Copy link
Contributor

I had already implemented one portion of this by accident apparently (completions support).

Adds version negotiation and a few other small breaking changes since I wanted to make a breaking change anyways to convert the protocol version to an enum.

Copy link

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

static const oldestSupportedVersion = ProtocolVersion.v2024_11_05;

/// The most recent version supported by the current API.
static const latest = ProtocolVersion.v2025_03_26;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be a values.last so that we do not have to update it? Or is making this fixed intentional so that we can work on supporting a protocol version before we set it to this latest field?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do see in the future us adding additional "known" but unsupported protocols here. Basically, when a new version gets released we can add the entry so that we can parse it etc and compare it.

I think I will rename this to latestSupported?

@jakemac53 jakemac53 requested a review from kenzieschmoll April 17, 2025 15:37
@jakemac53 jakemac53 merged commit bc0bd0a into main Apr 17, 2025
15 checks passed
@jakemac53 jakemac53 deleted the update-spec branch April 17, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants