-
Notifications
You must be signed in to change notification settings - Fork 5
Update analyze tool to use LSP, simplify tool #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would be good to wait for @bwilkerson's review as well.
import 'dart:convert'; | ||
|
||
import 'package:async/async.dart'; | ||
import 'package:stream_channel/stream_channel.dart'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing that the analysis server must already have some similar code. At some point we should look at sharing the implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I would probably move it to be a part of the language_server_protocol
package.
dart language-server
for errors, file watching, etc.In the future, we might try to use the DTD connection to talk, which won't change this code too much. But right now DTD has very limited support (read/write properties).
Closes #65 as well