Skip to content

Commit

Permalink
Use HttpMultiServer loopback (#2265) (#2267)
Browse files Browse the repository at this point in the history
This should close dart-lang/webdev#375
  • Loading branch information
grouma authored May 21, 2019
1 parent a56c940 commit 10de1d5
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
4 changes: 4 additions & 0 deletions build_daemon/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
`Stream<WatchEvent>`. This allows file change notifications to be sent as
batches of simultaneous changes, preventing over-triggering of builds.

## 0.6.1

- Use `HttpMultiServer` to better support IPv6 and IPv4 workflows.

## 0.6.0

- Add retry logic to the state file helpers `runningVersion` and
Expand Down
5 changes: 4 additions & 1 deletion build_daemon/lib/src/server.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import 'dart:convert';
import 'dart:io';

import 'package:built_value/serializer.dart';
import 'package:http_multi_server/http_multi_server.dart';
import 'package:pool/pool.dart';
import 'package:shelf/shelf_io.dart';
import 'package:shelf_web_socket/shelf_web_socket.dart';
Expand Down Expand Up @@ -79,7 +80,9 @@ class Server {
_removeChannel(channel);
});
});
_server = await serve(handler, 'localhost', 0);

_server = await HttpMultiServer.loopback(0);
serveRequests(_server, handler);
return _server.port;
}

Expand Down
1 change: 1 addition & 0 deletions build_daemon/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ environment:
dependencies:
built_collection: ^4.1.0
built_value: ^6.3.0
http_multi_server: ^2.0.0
logging: ^0.11.0
pedantic: ^1.0.0
package_resolver: ^1.0.6
Expand Down

0 comments on commit 10de1d5

Please sign in to comment.